Auto-tag alpha images in Git that we can generate full releases from #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvmiller89
force-pushed
the
rmiller-auto-ci-git-tag
branch
from
578306c
to
77bc0d6
Compare
|
This is difficult to test without actually merging and seeing how it works. If it messes up, we can delete the tag. |
lei-sumo
reviewed
Jul 30, 2019
|
|
||
| echo "Tagging git with v$new_alpha..." | ||
| git tag -a "v$new_alpha" -m "Bump version to v$new_alpha" | ||
| git push --tags origin master |
There was a problem hiding this comment.
Would this create too many tags in github? Do we have any concern there?
There was a problem hiding this comment.
It will create a tag for every PR that gets merged. I think that's fine though -- we can always re-evaluate if we hit some limit.
There was a problem hiding this comment.
+1 I'm okay with this, it helps keep track of which alpha tag corresponds to which commits as well
samjsong
approved these changes
Jul 30, 2019
lei-sumo
approved these changes
Jul 30, 2019
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically tag pushes to master with the same version we use to push the docker image. From these tags we can create releases in Github, and also perform diffs between tags/master.