Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-tag alpha images in Git that we can generate full releases from #103

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Auto-tag alpha images in Git that we can generate full releases from #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ci/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ elif [ -n "$DOCKER_PASSWORD" ] && [ "$TRAVIS_BRANCH" == "master" ] && [ "$TRAVIS
echo "Pushing alpha docker image with version $new_alpha"
echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin
docker push $DOCKER_TAG:$new_alpha

echo "Tagging git with v$new_alpha..."
git tag -a "v$new_alpha" -m "Bump version to v$new_alpha"
git push --tags origin master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this create too many tags in github? Do we have any concern there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will create a tag for every PR that gets merged. I think that's fine though -- we can always re-evaluate if we hit some limit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 I'm okay with this, it helps keep track of which alpha tag corresponds to which commits as well

else
echo "Skip Docker pushing"
fi
Expand Down