Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't install aws cli when already available in gh env with ecr-public command #1254

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Don't install aws cli when already available in gh env with ecr-public command #1254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .github/workflows/dev_builds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,6 @@ jobs:
- name: Build setup image
working-directory: deploy/docker/setup/
run: make build
# We need to install awscli v1 via pip because it contains a version
# that supports ecr-public while github actions environment on Ubuntu 20.04
# contains aws v2.1.4 which doesn't know about it yet.
# (support for ecr-public landed in v2.1.6)
# ref: https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md
- name: install awscli
run: |
pip install awscli
echo "/home/runner/.local/bin" >> $GITHUB_PATH
- name: Login to AWS public ECR
working-directory: deploy/docker/setup/
run: make login
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/release_builds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,6 @@ jobs:
- name: Build kubernetes-setup
run: make build BUILD_TAG=${{ steps.extract_tag.outputs.tag }}
working-directory: deploy/docker/setup/
# We need to install awscli v1 via pip because it contains a version
# that supports ecr-public while github actions environment on Ubuntu 20.04
# contains aws v2.1.4 which doesn't know about it yet.
# (support for ecr-public landed in v2.1.6)
# ref: https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md
- name: install awscli
run: |
pip install awscli
echo "/home/runner/.local/bin" >> $GITHUB_PATH
- name: Login to AWS public ECR
working-directory: deploy/docker/setup/
run: make login
Expand Down