Migrate prometheus pre 1.14 rules only when prometheus-operator.kubeTargetVersionOverride is set to 1.13.0-0 #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…argetVersionOverride is set to 1.13.0-0
pmalek-sumo
requested review from
andrzej-stencel,
frankreno,
kasia-kujawa,
perk-sumo and
sumo-drosiek
as code owners
sumo-drosiek
reviewed
Jan 8, 2021
| info "Removing prometheus kubeTargetVersionOverride='1.13.0-0'" | ||
| yq d -i "${TEMP_FILE}" "prometheus-operator.kubeTargetVersionOverride" | ||
| add_prometheus_pre_1_14_recording_rules "${TEMP_FILE}" | ||
| elif [[ -z "${RECORDING_RULES_OVERRIDE}" ]]; then |
There was a problem hiding this comment.
what about this condition? What if kubeTargetVersionOverride is unset?
There was a problem hiding this comment.
We don't want to add pre 1.14 rules then.
As per discussion with @frankreno
|
Also do we have test for cover that? |
All tests that specify |
sumo-drosiek
approved these changes
Jan 8, 2021
pmalek-sumo
deleted the
v2-migration-script-pre-1.14-prometheus-rules-map
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate only when
prometheus-operator.kubeTargetVersionOverrideis set to1.13.0-0.Testing performed