Add extensibility points in values.yaml for Fluentd plugins for logs #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzej-stencel
force-pushed
the
add-extra-output-plugin-conf-for-logs
branch
2 times, most recently
from
5322418
to
1e8bf3c
Compare
andrzej-stencel
force-pushed
the
add-extra-output-plugin-conf-for-logs
branch
from
1e8bf3c
to
683abf4
Compare
andrzej-stencel
force-pushed
the
add-extra-output-plugin-conf-for-logs
branch
from
683abf4
to
19fb5b5
Compare
andrzej-stencel
changed the title
andrzej-stencel
requested review from
frankreno,
kkujawa-sumo,
perk-sumo and
pmalek-sumo
as code owners
pmalek-sumo
approved these changes
Jan 27, 2021
sumo-drosiek
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fluentd.logs.containerssection invalues.yamlfile hasextraFilterPluginConfextensibility point to inject more plugins into the Fluentd configuration, but lacks theextraOutputPluginConfentry similar to existingfluentd.metrics.extraOutputPluginConf.Added the
extraOutputPluginConfentry tocontainerssection and also added bothextraFilterPluginConfandextraOutputPluginConftokubelet,systemdanddefaultsections.