Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-v2.0] Enable otlphttp exporter in tracing collection #1425

Merged
merged 1 commit into from Feb 15, 2021
Merged

[Backport release-v2.0] Enable otlphttp exporter in tracing collection #1425

merged 1 commit into from Feb 15, 2021

Conversation

github-actions[bot]
Copy link

Backport 5b2f816 from #1415

@github-actions github-actions bot requested a review from a team February 15, 2021 08:25
@perk-sumo perk-sumo added this to the v2.0 milestone Feb 15, 2021
sumo-drosiek
sumo-drosiek reviewed Feb 15, 2021
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmatyjasek-sumo Does this config work with otc 0.19.2-sumo?

@perk-sumo
Copy link
Contributor

I can see that on release-v2.0 there is even 0.16.2-sumo
https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/release-v2.0/deploy/helm/sumologic/values.yaml#L1892

@pmatyjasek-sumo
Copy link
Contributor

@sumo-drosiek yes it works on 0.19.2-sumo.

@sumo-drosiek
Copy link
Contributor

Sorry, asked about invalid version. I meant 0.16.2-sumo. I suppose PR should be closed and reopened due to CI
\

@perk-sumo
Copy link
Contributor

There is misunderstanding as otelagent and otelcol use two different OTC versions, I'm not sure that's what we want in here.

otelagent 0.16:
https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/main/deploy/helm/sumologic/values.yaml#L1913

otelcol 0.19:
https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/main/deploy/helm/sumologic/values.yaml#L2019

@perk-sumo
Copy link
Contributor

otelagent will be bumped in #1431

@perk-sumo perk-sumo closed this Feb 15, 2021
@perk-sumo perk-sumo reopened this Feb 15, 2021
@perk-sumo perk-sumo enabled auto-merge (rebase) February 15, 2021 12:54
@pmatyjasek-sumo @perk-sumo
Enable otlphttp exporter in tracing collection
7f50b63 
Signed-off-by: Patryk Matyjasek <pmatyjasek@sumologic.com>
@perk-sumo perk-sumo merged commit 6072962 into release-v2.0 Feb 15, 2021
@perk-sumo perk-sumo deleted the backport-1415-to-release-v2.0 branch February 15, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumo-drosiek sumo-drosiek sumo-drosiek left review comments

@perk-sumo perk-sumo perk-sumo approved these changes

@pmatyjasek-sumo pmatyjasek-sumo pmatyjasek-sumo approved these changes

@mat-rumian mat-rumian Awaiting requested review from mat-rumian

@pmm-sumo pmm-sumo Awaiting requested review from pmm-sumo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@perk-sumo @pmatyjasek-sumo @sumo-drosiek