Fix labels for k8s health check metrics and use versioned overrides yaml files #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvmiller89
approved these changes
Aug 29, 2019
| @@ -224,7 +224,7 @@ This manifest binds the default `cluster-admin` ClusterRole in your Kubernetes c | |||
| Download the Prometheus Operator `prometheus-overrides.yaml` from GitHub: | |||
|
|
|||
| ```sh | |||
| curl -LJO https://raw.githubusercontent.com/SumoLogic/sumologic-kubernetes-collection/master/deploy/helm/prometheus-overrides.yaml | |||
| curl -LJO https://raw.githubusercontent.com/SumoLogic/sumologic-kubernetes-collection/v0.1.0/deploy/helm/prometheus-overrides.yaml | |||
There was a problem hiding this comment.
should we add this step in #2 in the deployment doc as well?
samjsong
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Health check metrics are broken because the values.yaml contains the old labels "k8s-app=fluentd-sumologic". If we change it, we also need to update the README to instruct users to download versioned overrides yamls. I don't think manually updating the version in the URLs is scalable but I also don't know if just telling users to change the URL with the latest version is sufficient?
Testing performed