Labeling statefulset pvcs (#1597) #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
requested review from
andrzej-stencel,
frankreno,
kasia-kujawa,
perk-sumo and
pmalek-sumo
as code owners
| @@ -234,6 +234,9 @@ fluentd: | |||
| ## Add custom annotations to all fluentd sts pods(logs, metrics, events) | |||
| podAnnotations: {} | |||
|
|
|||
| ## Add custom labels to all fluentd statefulset PVC (logs, metrics, events) | |||
| pvcLabels: {} | |||
There was a problem hiding this comment.
It would be good to add pvcLabels to table available on this page: https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/release-v2.1/deploy/helm/sumologic/README.md
kasia-kujawa
approved these changes
May 14, 2021
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-2.1-bckprt-pvc-labels
branch
from
26b72b4
to
558305c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fill in your description here.
Testing performed