Migrate kubernetes_sumologic filter plugin #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei-sumo
approved these changes
Aug 30, 2019
|
It's copy & paste, except a few minor changes. To remain consistent with the other plugins in our repo, I changed Good catch on the null field value change. That's currently still in the |
rvmiller89
approved these changes
Aug 30, 2019
maimaisie
approved these changes
Aug 30, 2019
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
* Update Care EKS collector * Add a space, delete duplicate sourceCategory * nvm, we don't want spaces * Set sources as local variable to clean up filter_predicate * tf fmt * Let's try this again * one more time Co-authored-by: Mel Cone <7332210+melmaliacone@users.noreply.github.com> Co-authored-by: Mel Cone <mel.cone@nytimes.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves the
kubernetes_sumologicfilter plugin from the old repo to this repo, and builds locally rather than pulling the gem.We also duplicate the
hostmetadata and attach as a new fieldnodesince that makes more sense in the kubernetes context.Testing performed