Adding ability to specify for annotations for serviceAccounts #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sumo-drosiek
previously approved these changes
Aug 31, 2021
sumo-drosiek
dismissed
their stale review
Please add annotations to rest of the service accounts as well. It would be nice if you update charts README.md too
sumo-drosiek
approved these changes
Aug 31, 2021
sumo-drosiek
pushed a commit
that referenced
this pull request
Aug 31, 2021
…tions can be added (#1714) * Adding ability to specify for annotations for serviceAccounts * updating README.md, adding annotations to setup and cleanup
2 tasks
sumo-drosiek
pushed a commit
that referenced
this pull request
Aug 31, 2021
…tions can be added (#1714) * Adding ability to specify for annotations for serviceAccounts * updating README.md, adding annotations to setup and cleanup
sumo-backporter bot
pushed a commit
that referenced
this pull request
Aug 31, 2021
…tions can be added (#1714) * Adding ability to specify for annotations for serviceAccounts * updating README.md, adding annotations to setup and cleanup
sumo-drosiek
pushed a commit
that referenced
this pull request
Aug 31, 2021
…tions can be added (#1714) * Adding ability to specify for annotations for serviceAccounts * updating README.md, adding annotations to setup and cleanup
|
Thank you @nairb, I was looking for this today. Very timely! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to specify annotations for the serviceAccounts. Resolves #1644
Testing performed