Fix Helm template naming in yaml files #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvmiller89
force-pushed
the
rmiller-helm-yaml-test
branch
2 times, most recently
from
01d23c0
to
66df36a
Compare
lei-sumo
approved these changes
Sep 2, 2019
maimaisie
approved these changes
Sep 2, 2019
| @@ -12,26 +12,18 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this | |||
| If dryRun=true, we use fixed value "fluentd". | |||
There was a problem hiding this comment.
we can remove this comment
| {{- $name := default .Chart.Name .Values.nameOverride -}} | ||
| {{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" }} | ||
| {{- end -}} | ||
| {{- end -}} | ||
|
|
||
| {{/* | ||
| Create default fully qualified labels. | ||
| We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec). | ||
| If dryRun=true, we use the Chart name "sumologic" and do not include labels specific to Helm. |
rvmiller89
force-pushed
the
rmiller-helm-yaml-test
branch
from
cabf768
to
a686219
Compare
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes both Helm and YAML-based deployment by standardizing on
collection-sumologicapp labels (removing "fluentd" all together).Also removes spurious
release: collectionin prometheus overrides, which was causing problems with YAML-based prometheus operator deployment.Testing performed