RBAC for pre-install hook #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maimaisie
assigned frankreno, rvmiller89 and samjsong and unassigned frankreno, rvmiller89 and samjsong
rvmiller89
approved these changes
Sep 8, 2019
lei-sumo
approved these changes
Sep 9, 2019
| apiVersion: v1 | ||
| kind: ServiceAccount | ||
| metadata: | ||
| name: {{ template "sumologic.fullname" . }}-setup |
There was a problem hiding this comment.
Do we want to name all these new resources with the same name?
There was a problem hiding this comment.
yes, it's a very conventional thing to give resources the same name in helm as long as we don't have two or more resources of the same type with the same name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix RBAC error for pre-install hook
Testing performed