Update OTC to v0.38.1-sumo #1893
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Run some tests and overall it looks good |
| spans_per_second: -1 | ||
| probabilistic_filtering_ratio: 0.2 | ||
| spans_per_second: 1660 | ||
| num_traces: 200000 |
There was a problem hiding this comment.
That changes the default, doesn't it? Is that ok for the users? Are we planning to document this in the CHANGELOG.md/release notes?
There was a problem hiding this comment.
I don't think this is a concern since we never explained how to use prefilled values in values.yaml for cascading_filter. The initial idea was to provide instructions on how to just enable the processor in the pipeline, but this was never done and eventually we provide a template with instructions instead. So practically this might be considered a new thing.
I am pretty sure we want to mention OTC update in the changelog though
There was a problem hiding this comment.
Agree on including it in the Changelog.
I understand the explanation but this still in some way is a breaking change 😓 for our users. It was possible to have this configured in the old yaml "schema" and now it would change with this PR being merged, right?
There was a problem hiding this comment.
I think it won't change much but of course we can mention this as well. So essentially something like:
- Update OpenTelemetry Collector version to v0.38.1-sumo
- Move
insecureparameter to separate configuration variable - Fix OTLP/HTTP metadata tagging
- Update Cascading Filter to new version which adds filtering by number of errors and uses new config format
- Change the default number of traces for Cascading Filter to 200000
- Move
@mat-rumian what do you think?
There was a problem hiding this comment.
If you could add an entry about this change in the changelog that would be great 👍
There was a problem hiding this comment.
Updated the changelog and put some links there
pmm-sumo
force-pushed
the
bump-otc-cfp-bm
branch
from
f56de3b
to
3eda5ae
Compare
pmm-sumo
changed the title
|
@pmm-sumo Please update the description and we can merge it afterwards. |
pmm-sumo
changed the title
Description
Update OpenTelemetry Collector version to v0.38.1-sumo
by number of errors and switches to a new, easier to use config format
Testing performed