feat: add cri support to experimental otelcol log collector #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm-sumo
force-pushed
the
feat/otelcol-log-collector-containerd
branch
from
b5ab49b
to
bd5b5c0
Compare
swiatekm-sumo
force-pushed
the
feat/otelcol-log-collector-containerd
branch
4 times, most recently
from
3323a12
to
b61b08e
Compare
swiatekm-sumo
changed the title
perk-sumo
reviewed
Jan 19, 2022
| timestamp: | ||
| parse_from: time | ||
| layout_type: gotime | ||
| layout: '2006-01-02T15:04:05.000000000-07:00' |
There was a problem hiding this comment.
Why this particular date?
There was a problem hiding this comment.
swiatekm-sumo
force-pushed
the
feat/otelcol-log-collector-containerd
branch
from
b61b08e
to
8175c6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add CRI log format support to the OTC log collector. This gives us containerd support and enables integration tests for the collector on kind. Based on https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/examples/kubernetes/otel-collector-config.yml courtesy of @sumo-drosiek 馃檱 .
Checklist
Remove items which don't apply to your PR.
Testing performed