feat(otellogs): support tolerations, nodeSelector and affinity for daemonset #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emonset Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
3 tasks
pmalek-sumo
approved these changes
Feb 28, 2022
Comment on lines
+33
to
+44
| {{- if .Values.otellogs.daemonset.nodeSelector }} | ||
| nodeSelector: | ||
| {{ toYaml .Values.otellogs.daemonset.nodeSelector | indent 8 }} | ||
| {{- end }} | ||
| {{- if or .Values.otellogs.daemonset.affinity }} | ||
| affinity: | ||
| {{ toYaml .Values.otellogs.daemonset.affinity | indent 8 }} | ||
| {{- end }} | ||
| {{- if .Values.otellogs.daemonset.tolerations }} | ||
| tolerations: | ||
| {{ toYaml .Values.otellogs.daemonset.tolerations | indent 8 }} | ||
| {{- end }} |
There was a problem hiding this comment.
Those if blocks are nice to have but since you've added the default in values.yaml I'm wondering if we should keep them.
There was a problem hiding this comment.
IMHO, generated template is nicer with ifs than:
nodeSelector:
{}
Please create gh issue for that if you want to change it, as all other templates should be reviewed and changed too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support tolerations, nodeSelector and affinity for otellogs daemonset
Checklist
Remove items which don't apply to your PR.
Testing performed