Pin gem dependency versions; Fix metadata version string #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samjsong
approved these changes
Sep 27, 2019
lei-sumo
reviewed
Sep 27, 2019
| @@ -21,7 +21,7 @@ Gem::Specification.new do |spec| | |||
|
|
|||
| spec.add_runtime_dependency 'concurrent-ruby', '~> 1.1' | |||
| spec.add_runtime_dependency 'fluentd', ['>= 0.14.10', '< 2'] | |||
| spec.add_runtime_dependency 'kubeclient', '~> 4.4.0' | |||
| spec.add_runtime_dependency 'kubeclient', '~> 4.4' | |||
There was a problem hiding this comment.
what does this file do after pinning a static version?
There was a problem hiding this comment.
this allows >= 4.4 and < 5.0
lei-sumo
approved these changes
Sep 27, 2019
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Root issue for the problem:
was that in our metadata plugin we were defining required version as
~>4.4.0which only applies to>= 4.4.0and< 4.5. Overnightkubeclientreleased a4.5.0version which now fails the required version check.This PR fixes that issue, and also pins our external gem dependency versions to avoid surprises since otherwise our CI could randomly start failing at any time as projects release new major versions.
Testing performed