fix(otellogs): set resources on Otelcol logs collector daemonset #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The resources were already defined in `values.yaml` in the `otellogs.daemonset.resources` property, but this property was not being used in the daemonset template.
andrzej-stencel
force-pushed
the
otellogs-resources
branch
from
875999c
to
5a837fc
Compare
|
Maybe this is a good opportunity to add a template test for this Daemonset? EDIT: Nevermind, missed the test. |
perk
approved these changes
May 24, 2022
perk-sumo
approved these changes
May 24, 2022
swiatekm
approved these changes
May 24, 2022
Ermm there is a test for it, I'm fixing the test in this very PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resources were already defined in
values.yamlin the
otellogs.daemonset.resourcesproperty,but this property was not being used in the daemonset template.