Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorter OT Operator label value #2374

Merged
merged 4 commits into from
Jun 14, 2022
Merged

Shorter OT Operator label value #2374

merged 4 commits into from
Jun 14, 2022

Conversation

mat-rumian
Copy link
Contributor

@mat-rumian mat-rumian commented Jun 13, 2022 •
edited
Loading

Description

Set shorter names to OT Operator resources.

Reson:

one or more objects failed to apply, reason: Instrumentation.opentelemetry.io "stag-collection-sumologic-opentelemetry-operator-instrumentation" is invalid: metadata.labels: Invalid value: "stag-collection-sumologic-opentelemetry-operator-instrumentation": must be no more than 63 characters
Checklist
  • Changelog updated
Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@mat-rumian mat-rumian requested a review from a team as a code owner June 13, 2022 12:08
@github-actions github-actions bot added the documentation documentation label Jun 13, 2022
@mat-rumian mat-rumian changed the title Shorter ot operator names Shorter OT Operator label value Jun 13, 2022
andrzej-stencel
andrzej-stencel reviewed Jun 14, 2022
View reviewed changes
tests/helm/opentelemetry_operator_instrumentation_cr/static/instrumentation.output.yaml
@@ -4,9 +4,9 @@ apiVersion: opentelemetry.io/v1alpha1
kind: Instrumentation
metadata:
namespace: ot-operator1
name: RELEASE-NAME-sumologic-opentelemetry-operator-instrumentation
name: RELEASE-NAME-sumologic-ot-operator-instr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the -sumologic part if we already have the RELEASE-NAME part?

Suggested change
name: RELEASE-NAME-sumologic-ot-operator-instr
name: RELEASE-NAME-ot-operator-instr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I guess that comes from the sumologic.fullname part...

@mat-rumian mat-rumian merged commit f5e89bb into main Jun 14, 2022
@mat-rumian mat-rumian deleted the shorter-ot-operator-names branch June 14, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions approved these changes

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

Assignees
No one assigned
Labels
documentation documentation integration-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mat-rumian @andrzej-stencel