-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add experimental OT event collection #2379
Conversation
06de4ee
to
d1a172d
Compare
Note: this currently includes #2388, I'll rebase once that's merged to make the config table changes clearer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request contains invalid labels. Please remove all of the following labels: ['do-not-merge/hold']
This depends on SumoLogic/sumologic-otel-collector#620, and therefore probably on the 0.54.0 OT distro release. |
I would insist to test all possible values for |
We can consider |
That's a breaking change though, as events don't have a section under |
it is not until |
It is. If someone disables events by setting |
I was thinking rather about flag |
Does that actually help? We run into problems if someone enables both FluentD and OT events. In that case, |
we could enable otc events by default and control it by |
This builds on event collection with OpenTelemetry Collector introduced in #2379, but changes how event collection is configured. It does so by removing the property `otelevents.enabled` and instead adding `sumologic.events.enabled` and `sumologic.events.provider`. Also adding some more documentation around this and fixing some typos or misleading docs. With this change, every property does exactly one thing: - `sumologic.events.enabled` enables or disables events collection - `sumologic.events.provider` switches between Fluentd and Otelcol We also still support the (now deprecated) `fluentd.events.enabled` property to disable events collection with Fluentd.
Description
This adds event collection using OT. As we don't have an
events
subsection in thesumologic
section, I can't implement a simple switch like we have for metadata, and instead need to add a new section and depend on the user not to enable both at once.One thing of note is the approach to configuring OT. Instead of simply embedding the configuration in values.yaml, we instead treat it as a normal template, and then allow overriding it via a configuration field whose function will be similar to the current approach, but which is intended as a last resort escape hatch rather than the default way of configuring OT.
TODO:
Checklist
Testing performed