feat: adjust event collection configuration #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
andrzej-stencel
force-pushed
the
events-collection-changes
branch
from
fc263d8
to
4d25505
Compare
This replaces the `otelevents.enabled` property. With this change, every property does exactly one thing: - `sumologic.events.enabled` enables or disables events collection - `sumologic.events.provider` switches between Fluentd and Otelcol We also still support the (now deprecated) `fluentd.events.enabled` property to disable events collection with Fluentd.
The tests were using the undocumented and nonexisting `sumologic.events.enabled` property in a way that collided with the changes to events configuration.
andrzej-stencel
force-pushed
the
events-collection-changes
branch
from
6b0f3fa
to
3875712
Compare
swiatekm
approved these changes
Jul 6, 2022
Changing the number of expected endpoints created from 2 to 1, because the events endpoint is no longer being created when events are disabled.
It took me a good while to find the cause of the failures. Hopefully the additional comments will make it easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request builds on event collection with OpenTelemetry Collector introduced in #2379, but changes how event collection is configured. It does so by removing the property
otelevents.enabledand instead addingsumologic.events.enabledandsumologic.events.provider.Also adding some more documentation around this and fixing some typos or misleading docs.
For easier review, see individual commits.