Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tracing): move k8s_tagger to otelagent #2390

Merged
merged 10 commits into from
Jul 4, 2022
Merged

chore(tracing): move k8s_tagger to otelagent #2390

merged 10 commits into from
Jul 4, 2022

Conversation

mat-rumian
Copy link
Contributor

@mat-rumian mat-rumian commented Jun 24, 2022 •
edited
Loading

Description

This PR:

  • moves k8s_tagger processor from otelcol to otelagent.
  • enable otelagent and otelgateway by default when traces.enabled=true
Checklist
  • Changelog updated
Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@mat-rumian mat-rumian marked this pull request as ready for review July 4, 2022 09:05
@mat-rumian mat-rumian requested a review from a team as a code owner July 4, 2022 09:05
@mat-rumian mat-rumian changed the title [tracing] Move k8s tagger to OTel Distro Agent chore(tracing): move k8s_tagger to otelagent Jul 4, 2022
@github-actions github-actions bot added the documentation documentation label Jul 4, 2022
sumo-drosiek
sumo-drosiek reviewed Jul 4, 2022
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can also add to release information that from now, otelagent and otelgateway are going to be enable by default. It would be also nice to have info how to disable it in the docs somewhere

sumo-drosiek
sumo-drosiek approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

traces are disabled by default, so I'm fine :)

@mat-rumian mat-rumian merged commit 9f7dad5 into main Jul 4, 2022
@mat-rumian mat-rumian deleted the move-k8s-tagger-to-agent branch July 4, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

Assignees
No one assigned
Labels
documentation documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mat-rumian @sumo-drosiek