-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adjust event collection configuration #2407
Merged
Merged
Commits on Jul 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 94a11ac - Browse repository at this point
Copy the full SHA 94a11acView commit details
Commits on Jul 6, 2022
-
feat!: use
sumologic.events.enabled
propertyThis replaces the `otelevents.enabled` property. With this change, every property does exactly one thing: - `sumologic.events.enabled` enables or disables events collection - `sumologic.events.provider` switches between Fluentd and Otelcol We also still support the (now deprecated) `fluentd.events.enabled` property to disable events collection with Fluentd.
Configuration menu - View commit details
-
Copy full SHA for 089ba42 - Browse repository at this point
Copy the full SHA 089ba42View commit details -
Configuration menu - View commit details
-
Copy full SHA for a191e83 - Browse repository at this point
Copy the full SHA a191e83View commit details -
The tests were using the undocumented and nonexisting `sumologic.events.enabled` property in a way that collided with the changes to events configuration.
Configuration menu - View commit details
-
Copy full SHA for d46e4d7 - Browse repository at this point
Copy the full SHA d46e4d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3875712 - Browse repository at this point
Copy the full SHA 3875712View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7653ace - Browse repository at this point
Copy the full SHA 7653aceView commit details -
test(integration): fix otelcol logs test
Changing the number of expected endpoints created from 2 to 1, because the events endpoint is no longer being created when events are disabled.
Configuration menu - View commit details
-
Copy full SHA for c17e16d - Browse repository at this point
Copy the full SHA c17e16dView commit details -
test(integration): make tests more verbose
It took me a good while to find the cause of the failures. Hopefully the additional comments will make it easier.
Configuration menu - View commit details
-
Copy full SHA for 9074623 - Browse repository at this point
Copy the full SHA 9074623View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.