Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kube-prometheus-stack): update kube-prometheus-stack chart to 39.11.0 #2446

Merged
merged 20 commits into from
Sep 12, 2022

Conversation

sumo-drosiek
Copy link
Contributor

@sumo-drosiek sumo-drosiek commented Jul 22, 2022

Description

Update kube-state-metrics to v2.3.0. I need to revisit this PR in order to upgrade to the newest possible version and also in order to add this change to migration script


Checklist
  • Changelog updated
Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains invalid labels. Please remove all of the following labels: ['do-not-merge/hold']

@swiatekm
Copy link

You should also mark this as a breaking change.

@sumo-drosiek
Copy link
Contributor Author

Migration script: SumoLogic/sumologic-kubernetes-tools#275

@sumo-drosiek sumo-drosiek changed the title chore(prometheus): update prometheus chart to 32.0.1 chore(prometheus): update prometheus chart to 39.11.0 Sep 5, 2022
@github-actions github-actions bot added the documentation documentation label Sep 5, 2022
@sumo-drosiek sumo-drosiek changed the title chore(prometheus): update prometheus chart to 39.11.0 chore(kube-prometheus-stack): update kube-prometheus-stac chart to 39.11.0 Sep 5, 2022
@sumo-drosiek sumo-drosiek self-assigned this Sep 5, 2022
@sumo-drosiek
Copy link
Contributor Author

ToDo: To add CRD migrations to migration doc

@sumo-drosiek sumo-drosiek changed the title chore(kube-prometheus-stack): update kube-prometheus-stac chart to 39.11.0 chore(kube-prometheus-stack): update kube-prometheus-stack chart to 39.11.0 Sep 9, 2022
Dominik Rosiek and others added 10 commits September 9, 2022 11:50
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
CHANGELOG.md Outdated Show resolved Hide resolved
@andrzej-stencel
Copy link
Contributor

Probably need to add this version to the table at https://github.com/SumoLogic/sumologic-kubernetes-collection/tree/main/deploy#support-matrix
image

Dominik Rosiek added 6 commits September 9, 2022 14:56
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
…ated_reason metric

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
CHANGELOG.md Outdated Show resolved Hide resolved
@sumo-drosiek sumo-drosiek enabled auto-merge (squash) September 12, 2022 13:47
Comment on lines 1699 to 1700
repository: k8s.gcr.io/kube-state-metrics/kube-state-metrics
tag: v1.9.8
# Do not collect metrics for CertificateSigningRequest or Ingress resources.
# This is because the v1 version of kube-state-metrics uses API versions
# that are removed in Kubernetes v1.22.
collectors:
certificatesigningrequests: false
ingresses: false
tag: v2.3.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to specify the repository ang tag? Maybe we could just use the defaults now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I believe we could remove the kube-prometheus-stack.prometheus-node-exporter.image.tag?

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek sumo-drosiek merged commit 78fc366 into main Sep 12, 2022
@sumo-drosiek sumo-drosiek deleted the drosiek-kube-state-metrics-v2 branch September 12, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants