Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grafana from starting via Helm deployment #253

Merged
merged 1 commit into from Oct 28, 2019
Merged

Fix grafana from starting via Helm deployment #253

merged 1 commit into from Oct 28, 2019

Conversation

rvmiller89
Copy link
Contributor

@rvmiller89 rvmiller89 commented Oct 28, 2019 •
edited

Description

Fix described here: helm/charts#9793 (comment)

Tested it and it seems to work fine.

FYI: @lei-sumo @maimaisie

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in
  • helm install . --name collection --namespace sumologic -f values.yaml

frankreno
frankreno approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvmiller89 rvmiller89 merged commit 57b4799 into master Oct 28, 2019
@rvmiller89 rvmiller89 deleted the rmiller-fix-grafana-helm branch October 28, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankreno frankreno frankreno approved these changes

@samjsong samjsong samjsong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rvmiller89 @frankreno @samjsong