feat(otellogs)!: add config.merge option #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm-sumo
force-pushed
the
feat/otellogs/config
branch
from
e94eef4
to
d7dc51f
Compare
swiatekm-sumo
force-pushed
the
feat/otellogs/config
branch
from
d7dc51f
to
f7fddbc
Compare
andrzej-stencel
approved these changes
Nov 28, 2022
swiatekm-sumo
force-pushed
the
feat/otellogs/config
branch
from
f7fddbc
to
1536b69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logs and metrics metadata config has merge and override properties to directly modify otel config. Make this so for otellogs as well. This is a breaking change, as otellogs already had override, but the meaning of it was identical to merge. We can handle this via an automatic migration.
Migration PR: SumoLogic/sumologic-kubernetes-tools#393
This is pretty much identical to #2643. I've also fixed some minor issues with otellogs documentation.
Checklist
Testing performed