feat(events)!: add config.merge option #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm
force-pushed
the
feat/events/add-merge
branch
from
48c3a3d
to
798a13a
Compare
|
Please remove tmpcharts |
swiatekm
force-pushed
the
feat/events/add-merge
branch
from
798a13a
to
7c20260
Compare
Whoops, done. I also added the directory to .gitignore. |
sumo-drosiek
approved these changes
Nov 25, 2022
swiatekm
force-pushed
the
feat/events/add-merge
branch
from
7c20260
to
f896473
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logs and metrics metadata config has
mergeandoverrideproperties to directly modify otel config. Make this so for events as well. This is a breaking change, as events already hadoverride, but the meaning of it was identical tomerge. We can handle this via an automatic migration.Migration PR: SumoLogic/sumologic-kubernetes-tools#389
Checklist