Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup): add permission to modify secrets #2653

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Conversation

swiatekm
Copy link

Description

The setup Job needs permission to modify Secrets, not just create them.


Checklist
  • Changelog updated

@swiatekm swiatekm requested a review from a team as a code owner November 28, 2022 11:23
@github-actions github-actions bot added the documentation documentation label Nov 28, 2022
@swiatekm swiatekm enabled auto-merge (squash) November 30, 2022 16:07
@swiatekm swiatekm merged commit 2ea8ae7 into main Nov 30, 2022
@swiatekm swiatekm deleted the fix/setup/permissions branch November 30, 2022 16:19
@sumo-backporter
Copy link
Contributor

The backport to release-v2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-v2 release-v2
# Navigate to the new working tree
cd .worktrees/backport-release-v2
# Create a new branch
git switch --create backport-2653-to-release-v2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2ea8ae7441e58d80baa5aa2c00ba1f4474670465
# Push it to GitHub
git push --set-upstream origin backport-2653-to-release-v2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-v2

Then, create a pull request where the base branch is release-v2 and the compare/head branch is backport-2653-to-release-v2.

@swiatekm
Copy link
Author

This doesn't actually need a backport, the change which caused it was not applied to v2 because it was effectively breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants