Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation): scrape label added and updated #2875

Merged
merged 5 commits into from
Feb 16, 2023

Conversation

mat-rumian
Copy link
Contributor

@mat-rumian mat-rumian commented Feb 15, 2023

PR adds scrape labels to service related to otelcol-instrumentation. Label value changed from traces -> instrumentation.

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@mat-rumian mat-rumian requested a review from a team as a code owner February 15, 2023 14:03
@mat-rumian mat-rumian changed the title feat(instrumentation): fix instrumentation scraping feat(instrumentation): scrape label added and updated Feb 15, 2023
@github-actions github-actions bot added the documentation documentation label Feb 15, 2023
Copy link

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a test for this, but I'm ok with it as-is.

@mat-rumian mat-rumian enabled auto-merge (squash) February 16, 2023 15:18
@mat-rumian mat-rumian merged commit ca05b7f into main Feb 16, 2023
@mat-rumian mat-rumian deleted the fix-instrumentation-scraping branch February 16, 2023 15:31
@swiatekm swiatekm mentioned this pull request Feb 16, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants