Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cleanup.sh #2932

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Update cleanup.sh #2932

merged 2 commits into from
Mar 15, 2023

Conversation

ib-ak
Copy link
Contributor

@ib-ak ib-ak commented Mar 14, 2023 •
edited
Loading

fixes #2928

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@ib-ak ib-ak requested a review from a team as a code owner March 14, 2023 16:10
@swiatekm
Copy link

Thank you for the contribution! The change itself looks fine, can you also add a changelog entry for it? See https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/main/docs/dev.md#adding-a-changelog-entry for instructions.

@ib-ak
Copy link
Contributor Author

ib-ak commented Mar 15, 2023

@swiatekm-sumo I created the changelog manually. Let me know it something is not right.

@swiatekm swiatekm enabled auto-merge (rebase) March 15, 2023 13:49
@swiatekm swiatekm merged commit 74ecd3f into SumoLogic:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions approved these changes

@swiatekm swiatekm swiatekm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sumologic Cleanup fails with tcp: dial tcp: lookup '': no such host error
2 participants
@ib-ak @swiatekm