Fix alpha helm chart installation #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few fixes based on the failing automation tests:
New prometheus operator version introduced in Bump Chart Versions #299 seems to have added this admission webhook step that fails our helm installation. Since we're not using admission webhooks, we can disable this by setting
prometheus-operator.prometheusOperator.admissionWebhooks.enabled=false.Disables
tlsProxyin the new prometheus operator version as well since this was failing to start prometheus when enabled.Helm hook weights seem to expect string values, not numbers, so changing these back to strings after they were changed to numbers in Customizable annotations for setup resources #302
Testing performed