Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logs): use longer fingerprint only on K8s <1.24 #3070

Merged
merged 1 commit into from May 29, 2023

Conversation

swiatekm-sumo
Copy link
Contributor

@swiatekm-sumo swiatekm-sumo commented May 29, 2023

Only use the longer file fingerprint for log file identification on K8s versions which still have docker-shim. This is not necessary with containerd.

Fixes #2916

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@swiatekm-sumo swiatekm-sumo requested a review from a team as a code owner May 29, 2023 10:43
@swiatekm-sumo swiatekm-sumo merged commit 25efe9b into main May 29, 2023
57 checks passed
@swiatekm-sumo swiatekm-sumo deleted the fix/logs/fingerprint-length branch May 29, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log collector should use a lower fingerprint size for K8s >=1.24
2 participants