Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Travis CI Snap Helm version to 2.16 #312

Merged
merged 2 commits into from
Nov 25, 2019

Conversation

rvmiller89
Copy link
Contributor

Description

This is needed because our CI doesn't currently work with Helm v3, it will fail with Error: unknown flag: --client-only (among other issues).

For now, pin to the last stable Helm v2 release channel.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@rvmiller89
Copy link
Contributor Author

Can we go ahead and get this in (even though it deletes the libsonnet file)? This is needed to unblock our CI to fix the libsonnet stuff

Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix Ryan

@rvmiller89 rvmiller89 merged commit ff5244d into master Nov 25, 2019
@rvmiller89 rvmiller89 deleted the rmiller-pin-helmv2-snap-travis branch November 25, 2019 18:09
@maimaisie
Copy link
Contributor

Thanks Ryan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants