Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use empty endpoint URL by default for redirection #321

Merged
merged 4 commits into from
Nov 26, 2019
Merged

Use empty endpoint URL by default for redirection #321

merged 4 commits into from
Nov 26, 2019

Conversation

maimaisie
Copy link
Contributor

Description

We decided to use empty string for the endpoint config param so by default it will do auto URL redirection unless the user overrides it. This will work for both helm and non-helm installations.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@maimaisie maimaisie merged commit 3bfbc11 into master Nov 26, 2019
@maimaisie maimaisie deleted the maisie-base-url branch November 26, 2019 21:57
@sumo-drosiek sumo-drosiek mentioned this pull request Apr 24, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvmiller89 rvmiller89 rvmiller89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maimaisie @rvmiller89