Modify regexes to match both deprecated and new metrics in 1.16 #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maimaisie
requested review from
frankreno,
rvmiller89,
samjsong and
vsinghal13
samjsong
reviewed
Jan 22, 2020
| @@ -74,13 +74,13 @@ prometheus: | |||
| - url: http://collection-sumologic.sumologic.svc.cluster.local:9888/prometheus.metrics.apiserver | |||
| writeRelabelConfigs: | |||
| - action: keep | |||
| regex: apiserver;(?:apiserver_request_count|apiserver_request_latencies.*|etcd_request_cache_get_latencies_summary.*|etcd_request_cache_add_latencies_summary.*|etcd_helper_cache_hit_count|etcd_helper_cache_miss_count) | |||
| regex: apiserver;(?:apiserver_request_(?:count|total)|apiserver_request_(?:latencies|duration_seconds).*|etcd_request_cache_get_(?:latencies_summary|duration_seconds).*|etcd_request_cache_add_(?:latencies_summary|duration_seconds).*|etcd_helper_cache_hit_(?:count|total)|etcd_helper_cache_miss_(?:count|total)) | |||
There was a problem hiding this comment.
should the etcd metrics here be latency_seconds not duration_seconds?
There was a problem hiding this comment.
same with apiserver_request_duration_seconds, should this be apiserver_request_latency_seconds? based on your description
There was a problem hiding this comment.
ah I should change the description. they changed latency to duration in those metrics between 1.14 and 1.16
There was a problem hiding this comment.
thanks for the confirmation!
samjsong
approved these changes
Jan 22, 2020
rvmiller89
approved these changes
Jan 22, 2020
|
Is the change done in the way that will support older k8s version as well? |
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecated apiserver metrics:
apiserver_request_count->apiserver_request_totalapiserver_request_latencies_summary->apiserver_request_duration_secondsetcd_request_cache_get_latencies_summary->etcd_request_cache_get_duration_secondsetcd_request_cache_add_latencies_summary->etcd_request_cache_add_duration_secondsetcd_helper_cache_hit_count->etcd_helper_cache_hit_totaletcd_helper_cache_miss_count->etcd_helper_cache_miss_total(Verified the apiserver metrics are coming in 1.16, but the etcd ones are not, I think all of these 4 etcd metrics got removed in 1.17 but not sure why they are not showing up in 1.16 either)
Deprecated kubelet metrics:
kubelet_runtime_operations_latency_microseconds->kubelet_runtime_operations_duration_secondskubelet_docker_operations_latency_microseconds->kubelet_docker_operations_duration_secondskubelet_docker_operations_errors->kubelet_docker_operations_errors_total(Verified all of the old and new kubelet metrics are coming in 1.16)
Testing performed