Revert "Modify regexes to match both deprecated and new metrics in 1.16" #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvmiller89
approved these changes
Feb 3, 2020
|
The changed regexes match both deprecated and renamed metrics, and on 1.16 both sets of metrics are being generated and collected by fluentd if we keep this change. At least one of the metrics has very high cardinality and the increase in DPM is a concern. I'm still talking to Frank if we want to fix this and how for the major release |
maimaisie
force-pushed
the
revert-372-maisie-metric-renames
branch
from
c5d06c2
to
7f6ee32
Compare
maimaisie
force-pushed
the
revert-372-maisie-metric-renames
branch
from
7f6ee32
to
3e8c149
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #372 since this we have another minor release to make before the major release