Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(setup): pass log fields and collector fields via Terraform variables #3766

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

swiatekm
Copy link

Pass these as Terraform variables. Define the values in a terraform.tfvars.json file, which Terraform loads automatically.

Collector fields require that we know the Helm Chart version, so pass that in as an environment variable.

Checklist

  • Changelog updated or skip changelog label added

@swiatekm swiatekm marked this pull request as ready for review June 17, 2024 10:42
@swiatekm swiatekm requested a review from a team as a code owner June 17, 2024 10:42
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, Hope you tested it 🙈

@swiatekm swiatekm merged commit ad0af09 into main Jun 17, 2024
57 checks passed
@swiatekm swiatekm deleted the chore/setup/fields-tfvars branch June 17, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants