-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(setup,cleanup): don't use Helm templates in Terraform manifests #3761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
changed the title
chore(setup/cleanup): don't use Helm templates in Terraform manifests
chore(setup,cleanup): don't use Helm templates in Terraform manifests
Jun 13, 2024
swiatekm
force-pushed
the
chore/setup/refactor
branch
from
June 13, 2024 15:17
10531fc
to
5f0de22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request contains invalid labels. Please remove all of the following labels: ['do-not-merge/hold']
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows the entirety of the changes I want to make to our Terraform manifests used by the setup job. It is not meant to be merged - I plan to submit the changes in a series of smaller PRs. It's here so the changes can be viewed in a broader context.
There are three approaches to moving Helm templating outside Terraform manifests in this PR:
terraform.tfvars.json
file. In this file, we generate what we need by manipulating Helm dictionaries, and then convert them to JSON in one go.sources.tf.json
file. This file is then used as a reference for the actual manifests and scripts.