Zipkin plugins #411
Merged
Zipkin plugins #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 12, 2020 10:33
vsinghal13
approved these changes
Feb 14, 2020
samjsong
approved these changes
Feb 19, 2020
|
Do we want to add @perk-sumo to review? |
perk-sumo
reviewed
Feb 20, 2020
| @@ -9,6 +9,10 @@ spec: | |||
| selector: | |||
| app: {{ template "sumologic.labels.app" . }} | |||
| ports: | |||
| - name: zipkin-write | |||
There was a problem hiding this comment.
Don't we want to add this only when traces are enabled?
There was a problem hiding this comment.
Yeah, I think so 👍
perk-sumo
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add zipkin input and output plugins. As zipkin uses HTTP both plugins are basing on
in_httpandout_httpfluent pluginsTesting performed