Increase the resource limits on CPU and memory for fluentd deployment #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei-sumo
approved these changes
Jun 10, 2019
There was a problem hiding this comment.
Good testing you did! @samjsong This information is also useful for the baseline cc @ggarg2906sumo .
rvmiller89
suggested changes
Jun 10, 2019
| @@ -291,11 +291,11 @@ spec: | |||
| imagePullPolicy: Always | |||
| resources: | |||
| limits: | |||
| memory: 256Mi | |||
| cpu: "100m" | |||
| memory: 1000Mi | |||
There was a problem hiding this comment.
nit: make this 1Gi. 1000Mi is like the worst of both worlds... using base-2 nomenclature but giving it a base-10 value.
There was a problem hiding this comment.
haha, sounds good. thanks for the feedback Ryan
| requests: | ||
| memory: 256Mi | ||
| cpu: "100m" | ||
| memory: 700Mi |
There was a problem hiding this comment.
nit: stick to a base-2 value, 768Mi
rvmiller89
approved these changes
Jun 10, 2019
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the metrics I collected on CPU and Memory usage, I feel these are reasonable numbers for request and limit. This is sufficient for collecting up to 5MB/sec = 432GB/day rates. For greater loads, we can either increase the number of Fluentd replicas, or increase the CPU limits. Memory usage seems to be relatively stable even with higher loads.
FYI @ggarg2906sumo @lei-sumo @maimaisie @yuting-liu @frankreno