Support tracing in filter plugin #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
requested review from
rvmiller89,
samjsong,
vsinghal13,
mat-rumian,
pmm-sumo and
perk-sumo
sumo-drosiek
changed the title
sumo-drosiek
changed the title
perk-sumo
approved these changes
Mar 6, 2020
added 9 commits
March 6, 2020 09:17
sumo-drosiek
force-pushed
the
drosiek-filter-sumologic-tracing-source-host
branch
from
1d2a888
to
bf0ad55
Compare
|
Retroactive LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have a PR under discussion. We have requirement for traces to tag
sourceHostandsourceCategory. There is few possible way to solve this. This PR represents moreless set of changes/differences between traces and logs/metrics.I see few possible solutions for this issue:
@rvmiller89 @samjsong @vsinghal13 @perk-sumo @pmaciolek
I would like to know your thoughs
Testing performed