Add configurable event type filter #51
Conversation
| config_param :configmap_update_interval_seconds, :integer, default: 10 | ||
| config_param :watch_interval_seconds, :integer, default: 300 | ||
|
|
||
| def configure(conf) | ||
| super | ||
|
|
||
| @valid_types = ["ADDED", "MODIFIED", "DELETED"] |
There was a problem hiding this comment.
Is this a complete list of the event types? I couldn't find any docs on this, would appreciate if you could point me in the right direction
There was a problem hiding this comment.
that reminds me there is also an ERROR type. I think it's errors related to using the watch API. in that case there won't be a resource version returned, and when that happens we skip the event and start a new watch stream. I will try to find docs on this, but I haven't seen any docs TBH
There was a problem hiding this comment.
This code snippet shows the types. BOOKMARK is very interesting that I just discovered. It's an event that only contains a resource version for a resource. It acts like a heartbeat for watch that tells you even though you didn't get a watch event for a resource, there hasn't been any changes to that resource up to this resource version. more details here. But it is still in alpha so I don't think we want to add it here yet.
There was a problem hiding this comment.
Thanks for looking into it Maisie, that sounds good to me.
| config_param :configmap_update_interval_seconds, :integer, default: 10 | ||
| config_param :watch_interval_seconds, :integer, default: 300 | ||
|
|
||
| def configure(conf) | ||
| super | ||
|
|
||
| @valid_types = ["ADDED", "MODIFIED", "DELETED"] |
There was a problem hiding this comment.
Thanks for looking into it Maisie, that sounds good to me.
|
good catch 😅 |
* Add AD provider * Add linux build of the AD provider * Create AD groups to match Sumo Logic roles * Remove legacy AD provider * Fix formatting * Use different prefixes based on env
This PR adds a fluentd config param for specifying a list of event types to ingest. An error will be thrown if (1) the list is empty; (2) the list size exceeds three; (3) each element in the list is not one of ADDED, MODIFIED or DELETED (uses case-insensitive string compare, Ruby's
casecmpis case insensitive and returns 0 if two strings are the same ignoring case, ie,"ADDED".casecmp("addED") == 0)User can then have something like this: