Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurable event type filter #51

Merged
merged 3 commits into from
Jun 20, 2019
Merged

Add configurable event type filter #51

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
667a8a1
Add configurable event type filter
maimaisie Jun 19, 2019
070245d
Use casecmp?
maimaisie Jun 19, 2019
82e6126
Do not hardcode length of valid_types array
maimaisie Jun 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion fluent-plugin-events/lib/fluent/plugin/in_events.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,17 @@ class EventsInput < Fluent::Plugin::Input
config_param :namespace, :string, default: nil
config_param :label_selector, :string, default: nil
config_param :field_selector, :string, default: nil
config_param :type_selector, :array, default: ["ADDED", "MODIFIED"], value_type: :string
config_param :configmap_update_interval_seconds, :integer, default: 10
config_param :watch_interval_seconds, :integer, default: 300

def configure(conf)
super

@valid_types = ["ADDED", "MODIFIED", "DELETED"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a complete list of the event types? I couldn't find any docs on this, would appreciate if you could point me in the right direction

Copy link
Contributor Author

@maimaisie maimaisie Jun 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that reminds me there is also an ERROR type. I think it's errors related to using the watch API. in that case there won't be a resource version returned, and when that happens we skip the event and start a new watch stream. I will try to find docs on this, but I haven't seen any docs TBH

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code snippet shows the types. BOOKMARK is very interesting that I just discovered. It's an event that only contains a resource version for a resource. It acts like a heartbeat for watch that tells you even though you didn't get a watch event for a resource, there hasn't been any changes to that resource up to this resource version. more details here. But it is still in alpha so I don't think we want to add it here yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into it Maisie, that sounds good to me.

raise Fluent::ConfigError, "type_selector needs to be an array with maximum #{@valid_types.length} elements: #{@valid_types.join(", ")}." \
if @type_selector.length > @valid_types.length || !@type_selector.any? || !@type_selector.all? {|type| @valid_types.any? {|valid| valid.casecmp?(type)}}

normalize_param
connect_kubernetes
end
Expand Down Expand Up @@ -114,7 +120,7 @@ def start_watcher_thread
watcher.each do |entity|
begin
entity = JSON.parse(entity)
router.emit tag, Fluent::Engine.now, entity
router.emit tag, Fluent::Engine.now, entity if @type_selector.any? {|type| type.casecmp?(entity['type'])}
rv = entity['object']['metadata']['resourceVersion']
rescue => e
log.error "Got exception #{e} parsing entity #{entity}. Skipping."
Expand Down