Adjust fluentd names and app labels

[perk-sumo]

Description

Fill in your description here.

Testing performed

• ci/build.sh
• Redeploy fluentd and fluentd-events pods
• Confirm events, logs, and metrics are coming in

[sumo-drosiek]

I think we should stick to the templates :)
We could create templates for events, fluentd, otelcol and whatever else we have. for both names and labels

[perk-sumo]

That's a good point but let's do it in 1.1 and not change the 1.0 scope any further.
I've created an issue to keep track of that one: #574

[samjsong]

There's a few other places that we use collection-sumologic, for example ServiceAccount, ClusterRole, ClusterRoleBinding
Will we want/need to change these as well? Some of these also reference a label app=collection-sumologic

[perk-sumo]

Actually that's a very good question @samjsong !
Firstly I've created a massive PR with all of those places refactored.
But then, when I looked at how many things I needed to change and saw that I was still not happy with the outcome I was not so sure we'd like to change all of that just before the release.
I propose we do the smallest subset that makes sense for now and do a big refactor for 1.1 (including the #574 )

[vsinghal13]

LGTM, with the remaining changes to be done in 1.1

[samjsong]

Hmm, I'm afraid changing the names of those other resources might technically be a breaking change for non-helm users since we'd be leaving old resources behind. The user would have to manually delete the old ServiceAccount etc since kubectl apply has no concept of deletion

but I don't believe it'll have any impact in terms of functionality, just some leftover resources... if this is okay then I'm +1 and we can proceed with this plan

[perk-sumo]

Actually ServiceAccount is being used by fluentd, events and otelcol. So I think we should leave it as it is. That being said I've updated labels for HPA and ConfigMap as well, please find the second commit.

[samjsong]

Thanks Perk!