Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove -o flag #651

Merged
merged 1 commit into from May 20, 2020
Merged

remove -o flag #651

merged 1 commit into from May 20, 2020

Conversation

vsinghal13
Copy link
Contributor

@vsinghal13 vsinghal13 commented May 19, 2020 •
edited

Description

It seems like -o flag only works with Helm3 and not with Helm2.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13 vsinghal13 requested a review from frankreno May 19, 2020 21:30
frankreno
frankreno approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vsinghal13 vsinghal13 merged commit 7dd1e2c into master May 20, 2020
@vsinghal13 vsinghal13 deleted the vsinghal13-remove-flag-migration-doc branch May 20, 2020 02:07
@vsinghal13 vsinghal13 added this to the v1.0 milestone May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankreno frankreno frankreno approved these changes

@samjsong samjsong samjsong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vsinghal13 @frankreno @samjsong