Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Travis build due to default shallow git clone #702

Merged
merged 1 commit into from Jun 2, 2020
Merged

Fix Travis build due to default shallow git clone #702

merged 1 commit into from Jun 2, 2020

Conversation

perk-sumo
Copy link
Contributor

@perk-sumo perk-sumo commented Jun 2, 2020 •
edited

Description

Fix Travis build due to default shallow git clone

https://docs.travis-ci.com/user/customizing-the-build#git-clone-depth

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

sumo-drosiek
sumo-drosiek approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would be nice to add some description, at least to the PR 😉

@perk-sumo perk-sumo changed the title check Travis Fix Travis build due to default shallow git clone Jun 2, 2020
@sumo-drosiek
Copy link
Contributor

git describe didn't work correctly if there was more than 50 commits from last description(tag)

@perk-sumo perk-sumo closed this Jun 2, 2020
@perk-sumo perk-sumo reopened this Jun 2, 2020
@perk-sumo
[fix] Travis build failed to create proper build tags due to default …
384fc02 
…shallow git clone

'git describe' won't work correctly if there is more than 50 (Travis default) commits from the last description (tag)
https://docs.travis-ci.com/user/customizing-the-build#git-clone-depth
sumo-drosiek
sumo-drosiek approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work? 😄

@perk-sumo
Copy link
Contributor Author

Yeah, works now, Travis is happy :)

@perk-sumo perk-sumo merged commit 2b54a9f into master Jun 2, 2020
@perk-sumo perk-sumo deleted the fix-ci-build branch June 2, 2020 09:33
@sumo-drosiek
Copy link
Contributor

So am I 🥇

@perk-sumo perk-sumo mentioned this pull request Jun 2, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@perk-sumo @sumo-drosiek