Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add source category for default logs pipeline #780

Merged
merged 4 commits into from
Sep 14, 2020
Merged

add source category for default logs pipeline #780

merged 4 commits into from
Sep 14, 2020

Conversation

vsinghal13
Copy link
Contributor

Description

Solves #749

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13 vsinghal13 requested a review from a team July 16, 2020 18:18
@vsinghal13 vsinghal13 added this to the v1.3 milestone Jul 16, 2020
@vsinghal13 vsinghal13 linked an issue Jul 16, 2020 that may be closed by this pull request
Add Source Category customization options for default logs source #749
Closed
frankreno
frankreno approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumo-drosiek
Copy link
Contributor

@vsinghal13
Shouldn't we add it to the logs.source.containers.conf? Maybe create helm function for this plugin

@vsinghal13
Copy link
Contributor Author

vsinghal13 commented Sep 14, 2020 •
edited
Loading

@vsinghal13
Shouldn't we add it to the logs.source.containers.conf? Maybe create helm function for this plugin

Dominik, the logs.source.containers.conf file already uses the kubernetes_sumologic filter plugin. This is primarily added for the default(catch-all) section.

@vsinghal13 vsinghal13 merged commit 97c5a2d into master Sep 14, 2020
@vsinghal13 vsinghal13 deleted the vsinghal-add-source-category-default branch September 14, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankreno frankreno frankreno approved these changes

@samjsong samjsong samjsong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Add Source Category customization options for default logs source
5 participants
@vsinghal13 @sumo-drosiek @frankreno @samjsong @perk-sumo