move metrics server chart repo #890
Conversation
vsinghal13
requested review from
a team,
samjsong,
pmalek-sumo,
andrzej-stencel and
frankreno
and removed request for
a team
| create: true | ||
| extraArgs: | ||
| kubelet-insecure-tls: true | ||
| kubelet-preferred-address-types: InternalIP,ExternalIP,Hostname |
There was a problem hiding this comment.
Doesn't this looks like breaking change?
There was a problem hiding this comment.
the args are the same, just the key has changed from args to extraArgs and the apiServer.create was set to true by default in the earlier chart, so we are explicitly setting it true here.
Also, since we do not enable metrics-server by default, I think it won't be considered a breaking change. cc @frankreno
There was a problem hiding this comment.
So because of the key change, if customers have enabled and created a new values.yaml, would they need to make a change? The key to breaking change is if customers old values.yaml works w/o changes.
There was a problem hiding this comment.
yes, since the key to providing args is changed, if the customer has enabled it, then they will have to modify the values.yaml
| create: true | ||
| extraArgs: | ||
| kubelet-insecure-tls: true | ||
| kubelet-preferred-address-types: InternalIP,ExternalIP,Hostname |
There was a problem hiding this comment.
So because of the key change, if customers have enabled and created a new values.yaml, would they need to make a change? The key to breaking change is if customers old values.yaml works w/o changes.
|
Changed the milestone to |
# Conflicts: # ci/build.sh # deploy/helm/sumologic/requirements.yaml
* move metrics server chart repo * modify args for metrics-server startup * Generate new overrides yaml/libsonnet file(s). Co-authored-by: Travis CI <travis@travis-ci.org>
Description
4.3.1version as a dependencyRef: https://hub.helm.sh/charts/bitnami/metrics-server
Testing performed