Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nginx to the vagrant environment #924

Merged
merged 6 commits into from
Sep 21, 2020
Merged

Add nginx to the vagrant environment #924

merged 6 commits into from
Sep 21, 2020

Conversation

sumo-drosiek
Copy link
Contributor

Add nginx to the vagrant environment

@sumo-drosiek sumo-drosiek requested review from a team, samjsong, vsinghal13, andrzej-stencel, justrelax19 and perk-sumo and removed request for a team September 17, 2020 08:02
@sumo-drosiek sumo-drosiek added this to the v1.3 milestone Sep 17, 2020
pmalek-sumo
pmalek-sumo approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@pmalek-sumo pmalek-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an idea: since the Makefile is growing with the addition of applications I'd maybe split it into parts, e.g. main part and include others like nginx, redis etc

@sumo-drosiek
Copy link
Contributor Author

@pmalek-sumo I plan to do it together with moving commands to the scripts

perk-sumo
perk-sumo approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

justrelax19
justrelax19 approved these changes Sep 18, 2020
View reviewed changes
vagrant/Makefile Show resolved Hide resolved
@sumo-drosiek sumo-drosiek merged commit a714e84 into master Sep 21, 2020
@sumo-drosiek sumo-drosiek deleted the drosiek-vagrant-nginx branch September 21, 2020 08:08
@sumo-drosiek sumo-drosiek mentioned this pull request Sep 24, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samjsong samjsong samjsong approved these changes

@justrelax19 justrelax19 justrelax19 approved these changes

@perk-sumo perk-sumo perk-sumo approved these changes

@pmalek-sumo pmalek-sumo pmalek-sumo approved these changes

@vsinghal13 vsinghal13 Awaiting requested review from vsinghal13

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
5 participants
@sumo-drosiek @samjsong @justrelax19 @perk-sumo @pmalek-sumo