Fix: do not change timestamps for already existing helm charts #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perk-sumo
force-pushed
the
perk-fix-helm-package-dates
branch
from
4bc9455
to
b074bdf
Compare
sumo-drosiek
approved these changes
Oct 8, 2020
perk-sumo
force-pushed
the
perk-fix-helm-package-dates
branch
from
b074bdf
to
af14de0
Compare
perk-sumo
changed the title
pmalek-sumo
reviewed
Oct 8, 2020
The command `helm repo index` is changing timestamps for already existing charts. This seems to be intended: helm/helm#7363 Helm stable repo tests use this workaround: https://github.com/helm/charts/blob/c6e503ccfd9911dd06ea9ac389a40a3490637516/test/repo-sync.sh#L83-L90 This commit adds the mentioned workaround to our build.
perk-sumo
force-pushed
the
perk-fix-helm-package-dates
branch
from
af14de0
to
ef78254
Compare
|
@pmalek-sumo good idea, let's try removing |
pmalek-sumo
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command
helm repo indexis changing timestamps for already existing charts.This seems to be intended: helm/helm#7363
Helm stable repo tests use this workaround:
https://github.com/helm/charts/blob/c6e503ccfd9911dd06ea9ac389a40a3490637516/test/repo-sync.sh#L83-L90
This PR adds the mentioned workaround to our build.
It's a first step for #987
Testing performed