fix(sourceprocessor): fix templating for sourceCategoryPrefix #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| valueTemplate = prefix + valueTemplate | ||
|
|
||
| if doesUseAnnotation { |
There was a problem hiding this comment.
Why does it matter if we use annotations or not? Should prefix templating only work when using annotations?
There was a problem hiding this comment.
This is a good question to the author of the processor.
As I understand it: if we use the annotations, then we override the standard template value or the prefix, and then we can't use the preprocessed template attributes array.
andrzej-stencel
suggested changes
Nov 29, 2023
aboguszewski-sumo
force-pushed
the
ab-source-category-prefix-fix
branch
from
d9b253c
to
1908b1f
Compare
sumo-drosiek
approved these changes
Nov 30, 2023
andrzej-stencel
approved these changes
Dec 8, 2023
aboguszewski-sumo
force-pushed
the
ab-source-category-prefix-fix
branch
2 times, most recently
from
90fafcd
to
d425f78
Compare
|
@astencel-sumo I think that I added that test because there was no test that just checks the prefixing (I had some problems while implementing this and this test helped me). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1322 - please see the issue to see the reason why it was reopened.
related to #1339
It turns out that the previous fix was not enough, because the code was affected also in some other places. I also did a small refactor.